BUG: Fixed mingw.lib error #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes gh-647.
|
@gfyoung thanks for working on this one. With what Mingw32 version did you test this? I'd like to test this on my Mingw32 install next week (traveling now) before merging. |
|
(if I haven't looked at this by the end of next week, feel free to ping me) |
|
Sure thing. I'm not sure which number is the actual version number you're asking for, but my version of mingw32-base, which is the basic MinGW installation, is version 2013072200. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue in #647 in which attempts to compile
numpywith MinGW and Fortran result in a missingmingw.liberror. Implemented the change proposed in that issue, tested locally on my machine, and all tests pass.