-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Updated documentation wording and examples for np.percentile. #7125
Conversation
Examples had some factual errors. Wording updated in a couple of places.
instead). If the input contains integers, or floats of smaller | ||
precision than 64, then the output data-type is float64. Otherwise, | ||
the output data-type is the same as that of the input. | ||
If `q` is a single percentile and `axis=None`, then the return is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be the return value
or the result
rather than the return
@shoyer I have accepted all of your comments. While we are on the subject, please let me know if the following appears to be a bug or if it is just me:
Specifically, how is |
@madawilliams I think I don't know what's going on with |
This LGTM. I'll give other folks a day or two to comment and then merge. |
I did not think this was major enough to post on the mailing list. If you disagree, I will post it. I did some research and all of the interpolation methods look correct except midpoint. Midpoint is definitely messed up in the example I gave and I have added a patch (#7129). Is there any point to opening an issue now that I have the PR? |
Agreed, no need to ping the mailing list for this issue or open a separate issue for midpoint now that you have a PR. |
DOC: Updated documentation wording and examples for np.percentile.
Thanks! @charris we should consider backporting this doc fix to 1.11. |
Examples had some factual errors. Fixed up 80-char columns. Wording updated in a couple of places.