TST: Fixed f2py test for Anaconda non-win32 #7171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # for Python 3.x compatibility, we need to decode | ||
| # the bytestream (not str as in Python 2.x) as UTF-8 | ||
| version = version.decode('utf-8') |
There was a problem hiding this comment.
Can we use sys.version_info instead?
There was a problem hiding this comment.
Ah, yes. Good point. That will make things a lot simpler. Done.
When you run 'python -V' under Anaconda, it returns for example, 'Python 3.4.3 :: Continuum Analytics, Inc.' However, the original parsing of the version in 'test_f2py' assumed there was nothing following the version number, causing a ValueError because you can't assign three variables to four components that you get from splitting on the '.'
charris
added a commit
that referenced
this pull request
Feb 2, 2016
TST: Fixed f2py test for Anaconda non-win32
|
Thanks @gfyoung . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run
python -Vunder Anaconda (or Miniconda), it returns for example,Python 3.4.3 :: Continuum Analytics, Inc.However, the original parsing ofversionintest_f2pyassumed there was nothing following the version number, causing aValueErrorbecause you can't assign three variables to four components that you get from splitting on the.