Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Updated minor typos in function_base.py and test_function_base.py #7181

Merged
merged 1 commit into from
Feb 7, 2016

Conversation

madphysicist
Copy link
Contributor

Main correction was to fix up outputs in nanpercentile examples and make the docs look more like those of percentile.

@madphysicist
Copy link
Contributor Author

I would like to make the request, if such a thing is possible, to have this PR backported the same way as as #7180, assuming they are both accepted and 7180 is backported. The reason is that most of this change is to the documentation of nanpercentile, so it is very closely related to the code modifications of 7180.

but it will probably be fully or partially sorted. Default is
False. Note that, if `overwrite_input` is True and the input
is not already an ndarray, an error will be raised.
If True, then allow use of memory of input array (a) for calculations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings and comments should wrap at 72 columns, not 79, PEP 8 says so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't argue with PEP8. Fixed. Also, found a couple more typos and changed some wording around while fixing.

data-type is float64. Otherwise, the output data-type is the same
as that of the input.
A new array holding the result (unless `out` is specified, in
which case that array is returned instead). If the input
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could remove (...).

@madphysicist madphysicist deleted the doc-typos branch February 7, 2016 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants