-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Updated minor typos in function_base.py and test_function_base.py #7181
Conversation
I would like to make the request, if such a thing is possible, to have this PR backported the same way as as #7180, assuming they are both accepted and 7180 is backported. The reason is that most of this change is to the documentation of |
but it will probably be fully or partially sorted. Default is | ||
False. Note that, if `overwrite_input` is True and the input | ||
is not already an ndarray, an error will be raised. | ||
If True, then allow use of memory of input array (a) for calculations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstrings and comments should wrap at 72 columns, not 79, PEP 8 says so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't argue with PEP8. Fixed. Also, found a couple more typos and changed some wording around while fixing.
22eb43b
to
baf9cf8
Compare
data-type is float64. Otherwise, the output data-type is the same | ||
as that of the input. | ||
A new array holding the result (unless `out` is specified, in | ||
which case that array is returned instead). If the input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could remove (...)
.
f506270
to
f2c5b6a
Compare
f2c5b6a
to
917e530
Compare
DOC: Updated minor typos in function_base.py and test_function_base.py
Main correction was to fix up outputs in
nanpercentile
examples and make the docs look more like those ofpercentile
.