Check for no solution in np.irr Fixes #6744 #7332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -651,7 +651,7 @@ def irr(values): | |||
| """ | |||
| res = np.roots(values[::-1]) | |||
| mask = (res.imag == 0) & (res.real > 0) | |||
| if res.size == 0: | |||
| if res.size == 0 or res[mask].size == 0: | |||
There was a problem hiding this comment.
I think you can do this more simply with
if not mask.any():
...
There was a problem hiding this comment.
Do'h yea that makes sense. I've updated the PR with that change.
simongibbons
force-pushed
the
irr_empty_check
branch
from
8eae2a5
to
e24b98a
Compare
|
Coffee is the foundation of civilization. A few more hoops to traverse. Could you squash the commits? You can do that with |
simongibbons
force-pushed
the
irr_empty_check
branch
from
e24b98a
to
3fdf327
Compare
|
Squashed. |
|
Thanks. LGTM pending tests. |
charris
added a commit
that referenced
this pull request
Feb 29, 2016
Check for no solution in np.irr Fixes #6744
eric-wieser
added
component: numpy.lib.financial
and removed
component: numpy.lib
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the proposed fix for #6744