Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Install pytz in the CI. #7338

Merged
merged 1 commit into from
Feb 25, 2016
Merged

TST: Install pytz in the CI. #7338

merged 1 commit into from
Feb 25, 2016

Conversation

jakirkham
Copy link
Contributor

Fixes: #7335
Related: #7336

This should allow for some tests that require pytz to run during CI.

@jakirkham
Copy link
Contributor Author

May be worth backporting this to 1.11.x as well just to make sure we have fixed any silent failures. Then again, I think there was only one and we are planning on explicitly silencing it anyways.

@njsmith
Copy link
Member

njsmith commented Feb 25, 2016

Should it be installed on appveyor too? (I don't have an opinion but figure the question should be raised :-))

@jakirkham
Copy link
Contributor Author

I was thinking it when I opened the PR. I will add it.

This should allow for some tests that require `pytz` to run during CI.
@jakirkham
Copy link
Contributor Author

Added to both.

@jakirkham
Copy link
Contributor Author

Are there any other cases like these that you know of?

@njsmith
Copy link
Member

njsmith commented Feb 25, 2016

Not I. I guess you could grep through the skipped and known failure tests.

LGTM, feel free to merge once CI tests pass.

@njsmith
Copy link
Member

njsmith commented Feb 25, 2016

Umm, if you have commit access, I mean. I forgot you might not :-)

@jakirkham
Copy link
Contributor Author

Looks like git grep agrees with you.

I was going to ask if that was more a general comment or if you were meaning I should. Yeah, I don't.

@jakirkham
Copy link
Contributor Author

Weird, appears to be some issue with this new setuptools package in conda. I experienced the same problem locally (on Mac) when I tried to update earlier so it is not Windows specific. Added this issue. ( conda/conda#2127 ) Will see what they have to say.

charris added a commit that referenced this pull request Feb 25, 2016
TST: Install `pytz` in the CI.
@charris charris merged commit d6407a1 into numpy:master Feb 25, 2016
@jakirkham jakirkham deleted the use_pytz_ci branch February 25, 2016 18:07
@charris
Copy link
Member

charris commented Feb 25, 2016

Thanks @jakirkham .

@jakirkham
Copy link
Contributor Author

Of course.

I am going to add a backport PR for 1.11.x not that I think there will be any more problems, but just to make sure.

@jakirkham
Copy link
Contributor Author

Added the backport PR ( #7343 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants