-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Install pytz
in the CI.
#7338
Conversation
May be worth backporting this to 1.11.x as well just to make sure we have fixed any silent failures. Then again, I think there was only one and we are planning on explicitly silencing it anyways. |
Should it be installed on appveyor too? (I don't have an opinion but figure the question should be raised :-)) |
I was thinking it when I opened the PR. I will add it. |
This should allow for some tests that require `pytz` to run during CI.
47b8dcc
to
16416f0
Compare
Added to both. |
Are there any other cases like these that you know of? |
Not I. I guess you could grep through the skipped and known failure tests. LGTM, feel free to merge once CI tests pass. |
Umm, if you have commit access, I mean. I forgot you might not :-) |
Looks like I was going to ask if that was more a general comment or if you were meaning I should. Yeah, I don't. |
Weird, appears to be some issue with this new |
TST: Install `pytz` in the CI.
Thanks @jakirkham . |
Of course. I am going to add a backport PR for 1.11.x not that I think there will be any more problems, but just to make sure. |
Added the backport PR ( #7343 ). |
Fixes: #7335
Related: #7336
This should allow for some tests that require
pytz
to run during CI.