BUG: int overflow in reshape, fixes #7455, fixes #7293 #7456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return -1; | ||
| } | ||
| } | ||
| else { | ||
| s_known *= dimensions[i]; | ||
| else if(npy_mul_with_overflow_intp(&s_known, s_known, dimensions[i])) { |
There was a problem hiding this comment.
Missing space, but everything looks good too me.
jaimefrio
force-pushed
the
reshape_segfault
branch
from
820bb46
to
2bd5e6a
Compare
|
Fixed the spacing, thanks for the review. From looking at all those shape functions, I have the feeling that there has to be a simpler, cleaner way of rewriting all of that. Maybe some other day... |
|
Hehe, probably, though they also all have their quirks you have to keep alive probably ;). |
|
Anyway, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.