Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fixed iteration over additional bad commands #7522

Merged
merged 1 commit into from
Apr 7, 2016

Conversation

splendido
Copy link
Contributor

I found a typo within setup.py where the dictionary of bad_commands is automatically populated from a list using a default error message.
The variable controlled with the for cycle is commands while command is used within the cycle body.

@charris charris merged commit 104501e into numpy:master Apr 7, 2016
@charris
Copy link
Member

charris commented Apr 7, 2016

Thanks @splendido . Next time it would be good to make the commit message more informative and follow the recommendations in doc/source/dev/gitwash/development_workflow.rst for same.

@splendido splendido changed the title Fixed iteration over additional bad commands BUG: Fixed iteration over additional bad commands Apr 7, 2016
@splendido
Copy link
Contributor Author

Thanks @charris, I've edited the PR title/text to improve the contribution quality.
Next time I'll surely follow your standard workflow for the commit message as well.

Btw, would you suggest to make a dedicated branch also for very simple fixes like this one?

@charris
Copy link
Member

charris commented Apr 7, 2016

Yes, always do that, it will keep your life (and ours) simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants