MAINT: unify tup processing, move tup use to after all PyTuple_SetItem calls #7627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing |
|
Was this causing problems? |
|
yes it causes problems on PyPy |
|
Thanks @mattip . I can't help feeling this things could be cleaned up a bit more, but there you go. |
|
@charris: backporting is harmless but unnecessary; the only folks who care are pypy and this is only one item in their queue so 1.11.1 isn't going to work for them regardless. |
charris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTuplesare immutable once used, so the calls toPyDict_SetItem(that usePyTupletup) must be after all calls toPyTuple_SET_ITEM.