Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Remove memory leak in np.place #7715

Merged
merged 1 commit into from
Jun 8, 2016
Merged

BUG: Remove memory leak in np.place #7715

merged 1 commit into from
Jun 8, 2016

Conversation

gfyoung
Copy link
Contributor

@gfyoung gfyoung commented Jun 7, 2016

Title is self-explanatory. Closes #7714.

cc @aboettcher

@gfyoung
Copy link
Contributor Author

gfyoung commented Jun 7, 2016

Ran the offending code, and I no longer see the memory leak with this change. Architecture and versions:

OS: Ubuntu 14.04
Python: 2.7.11
numpy: 1.12.0.dev0+080c433 (this PR)
scipy: 0.18.0.dev0+01529bc

@aboettcher
Copy link

aboettcher commented Jun 7, 2016

I agree, no more memory leak with this version.

OS: Ubuntu 14.04.3 LTS
Pythion: Python 3.5.1
numpy: 1.12.0.dev0+080c433
scipy: 0.18.0.dev0+5a779fd

Great work! Thank you very much :-)

@charris charris merged commit d69c147 into numpy:master Jun 8, 2016
@charris
Copy link
Member

charris commented Jun 8, 2016

Thanks @gfyoung .

@gfyoung gfyoung deleted the str-replace-mem-leak branch June 8, 2016 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants