Fix ATLAS version detection #7840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ATLAS version check still depends on this function.
|
Could you expand on what the problem is? |
|
@charris Sure thing! I updated the main PR description with more details. |
|
Makes sense to me to revert the removal of |
|
@rgommers Thanks for taking a look. |
|
@llasram Thanks. |
|
Backported in #7851. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATLAS version detection still depends on the deprecated-and-removed
get_outputmethod. Restoring this function seems to be the easiest short-term fix.In more detail: within
numpy.distutils, thesystem_info.get_atlas_version()function is still implemented in terms of theconfig.config.get_output()method removed in release 1.10.0. Theget_atlas_version()function is written in such a way that it swallows the unexpectedAttributeError(or any other exception). When ATLAS is the selected BLAS implementation, this causes e.g. theget_info('blas_opt')['define_macros']list to include('NO_ATLAS_INFO', -1). It is unclear what this is intended to mean, and at least scikit-learn checks only for the presence ofNO_ATLAS_INFOand not the associated value, as seen in scikit-learn/scikit-learn#5489.Obviously longer-term
numpy.distutilsshould switch to a more appropriate mechanism for identifying the ATLAS version, but restoringget_output()gets the existing detection function working until it can be re-implemented.