Backport 7937, BUG: Guard against buggy comparisons in generic quicksort. #7953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic types may have buggy comparison operators in which case the sentinal values in quicksort cannot be counted on to keep the pointers from running off the ends of the array. The solution here is to explicitly check that the pointers are in bounds when sorting generic types. Closes numpy#7934.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7937
Generic types may have buggy comparison operators in which case the
sentinal values in quicksort cannot be counted on to keep the pointers
from running off the ends of the array. The solution here is to
explicitly check that the pointers are in bounds when sorting generic
types.
Closes #7934.