DOC: change all non-code instances of Numpy to NumPy #8021
Conversation
|
It looks good. However, I would not change the release notes - it might look strange that the last commit is after the release date. |
Instances remain for NumpyVersion and Numpy.rec.fromarrays that are references to code. Release notes were left unchanged. see issue numpy#7986
pdebuyl
force-pushed
the
spelling_doc
branch
from
6e7c41a
to
773e3ca
Compare
|
Forced pushed the PR with no changes to release notes. |
|
I also opened an associated PR for the website: numpy/numpy.org#5 |
|
Should I also do the code part? The docstrings are full of both both versions, including C files in multiarray, umath and mtrand. |
|
I think the docstrings and comment could be updated, but not the source code. |
The strings in error messages were left untouched
the files in doc/ and numpy/ were covered in previous commits
charris
changed the title
|
It looks good to me. |
| @@ -1,4 +1,4 @@ | |||
| Numpy.i: a SWIG Interface File for NumPy | |||
| NumPy.i: a SWIG Interface File for NumPy | |||
There was a problem hiding this comment.
This should be changed to all lower case, numpy.i, which is the actual name of the file it refers to.
|
Thanks a lot for doing this! That was a lot of NumPy to read, but I found one instance that needs to be corrected, see inline comment. My diagonal looking at the rest didn't find anything else. Should I merge it once you change the SWIG file name, or is there anything else you want to include in this PR? |
|
You are welcome :-) It is my pleasure to contribute to NumPy in the extent of my abilities and time! The PR is complete as it is. There is also a need for a statement about the capitalization somewhere (see #7986) but that is for later. |
|
@pdebuyl @jaimefrio could you also take a look at numpy/numpy.org#5? Should these changes be mentioned in the release notes for the next release? |
| @@ -2,4 +2,4 @@ | |||
| Numarray compatibility | |||
| ********************** | |||
|
|
|||
| The numarray module was removed in Numpy 1.9. | |||
| The numarray module was removed in NumPy 1.9. | |||
There was a problem hiding this comment.
Should make the 1.9. 1.9.0. as below.
| @@ -742,7 +742,7 @@ def fit(cls, x, y, deg, domain=None, rcond=None, full=False, w=None, | |||
| deg : int or 1-D array_like | |||
| Degree(s) of the fitting polynomials. If `deg` is a single integer | |||
| all terms up to and including the `deg`'th term are included in the | |||
| fit. For Numpy versions >= 1.11 a list of integers specifying the | |||
| fit. For NumPy versions >= 1.11 a list of integers specifying the | |||
|
I made comments about changing version references from the form |
|
Hi, |
|
Thanks Pierre! |
|
Thanks @btel @charris @jaimefrio for guidance :-) |
Instances remain for NumpyVersion and Numpy.rec.fromarrays that are
references to code.
see issue #7986