Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Vendorize tempita. #8096

Merged
merged 1 commit into from
Oct 1, 2016
Merged

Conversation

charris
Copy link
Member

@charris charris commented Sep 28, 2016

ENH: Vendorize tempita.

Copy tempita from https://github.com/gjhiggins/tempita with a few
changes to remove the six dependency. This removes a dependency on
Cython's tempita, which is not to be relied on as it is considered by
the Cython folks to be an implementation detail.

The cythonize.py script is changed to use the vendorized tempita.

@charris charris added this to the 1.12.0 release milestone Sep 28, 2016
@charris
Copy link
Member Author

charris commented Sep 28, 2016

Note that the system tempita will be used if installed. We might want to rename the module npy_tempita or some such if we make modifications to it. For instance, the current version here has some changes from the version currently on PyPI. I've pushed those changes upstream.

@seberg
Copy link
Member

seberg commented Sep 28, 2016

Didn't look at it, but to be on the safe side, should there be some reference to the original source of the code (possibly including a license snippet)?

Copy tempita from https://github.com/gjhiggins/tempita with a few
changes to remove the six dependency.  This removes a dependency on
Cython's tempita, which is not to be relied on as it is considered by
the Cython folks to be an implementation detail. The package is named
npy_tempita so that it can always be distinguished from an installed
tempita.

The cythonize.py script is changed to use the vendorized tempita.
@charris charris merged commit 5d914da into numpy:master Oct 1, 2016
@charris charris deleted the add-tempita-to-tools branch October 1, 2016 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants