BUG: core: add missing error check after PyLong_AsSsize_t #8114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
reviewed
Oct 3, 2016
| @@ -3981,6 +3981,9 @@ array_shares_memory_impl(PyObject *args, PyObject *kwds, Py_ssize_t default_max_ | |||
| } | |||
| else if (PyLong_Check(max_work_obj)) { | |||
| max_work = PyLong_AsSsize_t(max_work_obj); | |||
| if (PyErr_Occurred()) { | |||
There was a problem hiding this comment.
LGTM, two small comments (which I don't care much about)
- Could use
PyNumber_Indexhere, which is a bit more general then the long check, but also forbids floats, etc. - Could make it
if ((max_work == -)1 && (PyErr_Occured())) {AFAIK.
There was a problem hiding this comment.
(Or PyArray_PyIntAsIntp` which is however much the same.
There was a problem hiding this comment.
The Python 3 manual doesn't mention the -1 return value, so I didn't add that...
There was a problem hiding this comment.
oh, really, did that change in python 3, seems odd?
|
Still wondering a bit about that -1, but it does not really matter here anyway. Thanks Pauli! |
|
Checked the code if you are curious, the -1 return value is used all over in cpython master, I think its a documentation oversight, but no matter. |
|
Yes, I'm pretty sure they didn't actually change it since it'd probably
wreak havoc everywhere.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial bugfix. PyLong can overflow ssize_t, so need to check error.