improve configure checks for broken systems #8141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some people use new compilers with old linkers so the target attribute check for AVX is not enough closes numpygh-8128
OSX 10.11 ships a clang that uses it but does not implement the necesary library function closes numpygh-8130
|
@rgommers can you check this again on mac, my previous patch had an error that also made it work |
|
also works, and LGTM as far as I understand this patch |
|
Let's give this a shot. Thanks Julian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check that linker can handle AVX and make sure
__builtin_cpu_supportsis not optimized away.