Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: added example with empty indices for a scalar, #8138 #8156

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

mattharrigan
Copy link
Contributor

Added an example to einsum showing how you can leave indices blank for a scalar. This is my first ever pull request to an open source project. Closes issue #8138

@charris
Copy link
Member

charris commented Oct 14, 2016

Thanks @mattharrigan .

@mattharrigan
Copy link
Contributor Author

Do I need to close the issue?

@charris
Copy link
Member

charris commented Oct 14, 2016

I closed it. What you should do is put Closes #8138. in the body of the commit message. I'd also leave the issue number out of the commit message summary line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants