Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: specialize name of dev package by interpreter #8202

Merged
merged 1 commit into from
Oct 22, 2016
Merged

ENH: specialize name of dev package by interpreter #8202

merged 1 commit into from
Oct 22, 2016

Conversation

mattip
Copy link
Member

@mattip mattip commented Oct 22, 2016

tested by moving Python.h by hand and then running setup.py build_ext

@charris
Copy link
Member

charris commented Oct 22, 2016

So both Python and PyPy supply the header? Is it the same header?

@mattip
Copy link
Member Author

mattip commented Oct 22, 2016

The file name is the same, but the include path is different and the contents are different, as are the contenct of many of the include files. Distribution package managers handle setting up the path (and virtualenv does as well) so it Just Works(tm)
I feel this commit is a bit silly, most users should be able to s/python/pypy/ without prompting, but we had someone complain

@charris charris merged commit ecfaa9b into numpy:master Oct 22, 2016
@charris
Copy link
Member

charris commented Oct 22, 2016

OK, bit cumbersome but harmless. Thanks @mattip .

@mattip mattip deleted the missing-Python.h branch June 1, 2017 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants