BUG: Better check for invalid bounds in np.random.uniform. #8227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimuldal
force-pushed
the
uniform_inf_check
branch
from
e4814a0
to
2cab7c9
Compare
alimuldal
changed the title
|
Could you fix up the commit message? All lines should be <=72 characters with hard breaks and a blank line after the summary line. Something like It would be extraordinary if the extended explanation were too detailed ;) |
charris
changed the title
alimuldal
force-pushed
the
uniform_inf_check
branch
4 times, most recently
from
139eb03
to
341ed78
Compare
bashtage
reviewed
Nov 1, 2016
| fscale = PyFloat_AsDouble(temp[i]) | ||
| if not npy_isfinite(fscale): | ||
| raise OverflowError('Range exceeds valid bounds') | ||
|
|
||
| Py_INCREF(temp) # needed to get around Pyrex's automatic reference-counting | ||
| # rules because EnsureArray steals a reference | ||
| odiff = <ndarray>PyArray_EnsureArray(temp) |
There was a problem hiding this comment.
You could just use not np.any(np.isfinite(odiff)) here rather than manually looping. This is used multiple places, e.g.,
alimuldal
force-pushed
the
uniform_inf_check
branch
from
341ed78
to
0d18ae1
Compare
Also check for invalid bounds when low= and high= are arraylike rather than scalar (closes numpy#8226)
alimuldal
force-pushed
the
uniform_inf_check
branch
from
0d18ae1
to
f5bb42f
Compare
|
Thanks @alimuldal . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8226