MAINT: let average preserve subclass information. #8290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Nov 19, 2016
| For ndarray subclasses, ``numpy.average`` will now return an instance of the | ||
| subclass, matching the behavior of most other numpy functions such as ``mean``. | ||
| As a consequence, also calls that returned a scalar may now return a subclass | ||
| array scalar. |
There was a problem hiding this comment.
Could you also add something under Compatibility notes? If you look In the 1.12 notes there is a subsection FutureWarning to changed behavior that has a list of changes.
|
LGTM modulo release note. One release would normally be a bit short, but this looks almost like a bug fix to me. |
This behaviour matches that for most other numpy functions (such as np.mean). It was initially slated for 1.12, but replaced by a FutureWarning. Hence, this is for 1.13.
mhvk
force-pushed
the
average-preserve-subclasses
branch
from
99cbb78
to
3f3d205
Compare
|
OK, I added the additional entry. I kept the original one in the API change section; that is what you meant, correct? As for the short warning period, I think that should be fine, given that we felt it was almost OK to just add to 1.12 (and it does feel more like an oversight/bug than anything else). |
|
Thanks @mhvk. I'll shorten the list entry later on, but yes, that is what I had in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaviour matches that for most other numpy functions (such as np.mean). It was initially slated for 1.12 (#7382), but replaced by a FutureWarning (#7433). Hence, this is for 1.13.