-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Make f2py respect kind specifications for real parameters #8299
Conversation
LGTM modulo some small nits. |
I add the comment here again because the referenced section is "outdated". I am sorry that this commit is now much more complex... Could you please review the changes made regarding the complex case. I realize that it still does not correctly evaluate the complex numbers. But providing a complete parser for the complex numbers is a bit difficult (and besides, all this fixes are warnings). |
How about you just make this about the real case and deal with the complex case in another PR? I'm happy to put the simple case in 1.12.0, but more complicated things might need to wait. I'm curious about the warnings, are you saying that this isn't needed except to avoid warnings? |
Ok, I will then probably not make the PR for the complex case, my current fix only partly solves the problem. I will comment in this PR what needs to be done. As for the warning, without this PR the compilation of the fortran code will produce this:
while with the PR the above message is not present. |
Could you squash the commits into one? Use |
e59df17
to
367da29
Compare
Ok, done! :) |
Fortran sources with parameters having kind-specifiers where not correctly intercepted in the crackfortran.py source. The reason was a restrictive check for only integer specifiers which did not split real's into the correct number. Furthermore, several tests has been added which tests the different kind specifiers and their use in codes, also all of them together. Signed-off-by: Nick Papior <nickpapior@gmail.com>
367da29
to
8a7e7a4
Compare
@charris done. Thanks. |
Looks good, thanks @zerothi . |
Fortran sources with parameters having kind-specifiers
where not correctly intercepted in the crackfortran.py
source. I.e.
The reason was a restrictive check for only integer specifiers
which did not split real's into the correct number.
Furthermore, several tests has been added which tests the different
kind specifiers and their use in codes, also all of them together.