BLD: blacklist powl (longdouble power function) on OS X. #8318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Ralf. |
WarrenWeckesser
added a commit
to WarrenWeckesser/numpy
that referenced
this pull request
Aug 27, 2020
The use of the math library powl was blacklisted on Mac OSX (numpygh-8318) because powl(0, y) would trigger a divide-by-zero warning even when y > 0 (issue numpygh-8307). This change creates npy_powl on OSX that avoids the spurious warning by not calling powl when x = 0 and y > 0. The change in npy_math_internal.h.src moves the handling of pow out of a template repeat-loop, so powl and powf are handled individually. This allows the creation of npy_powl to be specialized when NPY_OS_DARWIN is defined. Closes numpygh-8608.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-8307