Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix test_api test that fails intermittently in python 3 #8337

Merged
merged 1 commit into from
Dec 4, 2016

Conversation

J-Sand
Copy link
Contributor

@J-Sand J-Sand commented Dec 4, 2016

This test is very occasionally failing on my machine in python 3. In python 3 ndarray.data gives a memoryview object, and the str of a memoryview is just "<memory at [address of memoryview object]>", so the only reason the test usually works is because the first memoryview gets deallocated and then the second one gets allocated in exactly the same place. bytes gives you the actual underlying data in both 2 and 3.

@charris charris added this to the 1.12.0 release milestone Dec 4, 2016
@charris charris merged commit fc03618 into numpy:master Dec 4, 2016
@charris charris removed this from the 1.12.0 release milestone Dec 4, 2016
@J-Sand J-Sand deleted the test_api_fix branch December 4, 2016 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants