Switch to the PyPI version of plex to generate lapack_lite #8377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that |
eric-wieser
force-pushed
the
pypi-plex
branch
from
a40ebcb
to
4c63fe1
Compare
|
This should be good to review now |
Could you add that prominently at the top of Changes look good to me. |
charris
reviewed
Dec 29, 2016
| @@ -2,11 +2,10 @@ | |||
| from __future__ import division, absolute_import, print_function | |||
|
|
|||
| import sys, os | |||
| from io import StringIO | |||
| from io import BytesIO as StringIO | |||
There was a problem hiding this comment.
Could we just use BytesIO instead of StringIO?
There was a problem hiding this comment.
Oops, thought I hadn't left that in
|
Shame that Plex seems to be abandonware since 2009-12-06. It will probably never be made Python3 compatible. |
This gives exactly the same output as before
This now runs correctly on python 2, whereas before it did not run at all
eric-wieser
force-pushed
the
pypi-plex
branch
from
4c63fe1
to
79988e1
Compare
It's now in there in various places |
|
Merged, thanks @eric-wieser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version, 1.1.4, was not even packaged with a
setup.py, making installation harder. Now it can just be installed (manually) from PIP.This was tested with the lapack 3.0.0 source (not the debian lapack3 package as was used before), and was found to have identical output before and after this changeset.