BUG: Ensure inf/nan removal in assert_array_compare is matrix-safe. #8468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about testing all the code paths --- for both x and y, one case with
nan & inf, one with only nan, one without either, and loop over the
cartesian product of all combinations.
|
mhvk
force-pushed
the
testing-utils-assert-equal-safe-for-matrices
branch
from
dc4c426
to
960ec0a
Compare
|
@pv - OK, I added a few more tests. |
|
OK, can't think of an obvious nicer solution, so works for me. Thanks, hopefully its fine now.... |
|
Ah, well the naming of the commit could have been better.... |
seberg
changed the title
|
Oops, sorry about that. |
|
No worries, just pressed the button before noticing :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regression introduced by #8452.