Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: use env in shebang instead of absolute path to python #8474

Merged
merged 2 commits into from
Jan 15, 2017
Merged

MAINT: use env in shebang instead of absolute path to python #8474

merged 2 commits into from
Jan 15, 2017

Conversation

ssalonen
Copy link
Contributor

Fixes #8472

charris
charris reviewed Jan 15, 2017
View reviewed changes
numpy/core/tests/test_arrayprint.py
@@ -1,4 +1,4 @@
#!/usr/bin/python
#!/usr/bin/env python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just remove it here, tests are not run as scripts. There are two other files where it could be removed

  • numpy/distutils/tests/test_misc_util.py
  • numpy/fft/tests/test_helper.py

@charris
Copy link
Member

charris commented Jan 15, 2017

Your commit message is too long, all lines <= 72 characters. Probably just move the Fixes bit into the body of the message.

@ssalonen
Copy link
Contributor Author

Now removed shebang completely from test modules. Commit message shortened.

@charris charris merged commit a5d71d6 into numpy:master Jan 15, 2017
@charris
Copy link
Member

charris commented Jan 15, 2017

Thanks @ssalonen .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris left review comments

Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ssalonen @charris