BUG: Prevent crash for length-0 input to fromrecords #8486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahaldane Piing. |
|
Sure, it looks like an improvement. I briefly thought about unintended consequences (eg, what can happens if someone puts in variable-length tuples) but I didn't see any problems. @eric-wieser Could you squash to commits together? I'd also prefer a little one-line test somewhere. I would tack it on in the end of |
This fixes: * The case when len(recList) == 0 and dtype is not None * The case when np.ndim(recList) > 1 In both cases, this would previously IndexError
|
@ahaldane: Tests added, and passing, and all three commits squashed |
|
LGTM, and nice extra tests. Merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the dtype is provided, passing a length-0 input is perfectly sensible