BUG: fix mean for float 16 non-array inputs #8524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0k
suggested changes
Jan 24, 2017
| @@ -4380,6 +4380,12 @@ def setUp(self): | |||
| self.omat = np.array([Decimal(repr(r)) for r in self.rmat.flat]) | |||
| self.omat = self.omat.reshape(4, 5) | |||
|
|
|||
| def test_python_type(self): | |||
| for x in (np.float16(1.), 1, 1., 1+0j): | |||
There was a problem hiding this comment.
To have a test that triggers the bug fixed in this PR, you may want to add [np.float16(1.)] to this tuple (i.e., a float16 wrapped in a list). The others don't run into the is_float16_result and not hasattr(a, "dtype") case.
There was a problem hiding this comment.
all tests are scalars wrapped into a list, though just scalars might be useful too
There was a problem hiding this comment.
all tests are scalars wrapped into a list
Ooops, right. Great then! Good to merge from my perspective. Thank you for taking this!
f0k
approved these changes
Jan 24, 2017
|
Thanks Julian. Should I do the backport? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.