BUG: Fix problems detecting runtime for MSYS2 compiler on Windows #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The msvccompiler module is made in the same mold as the msvc9compiler module; saving the two environment variables around the call to initialize. However, the signaure in the msvccompiler module's version of the MSVCCompiler class, there is no plat_name argument to the method. Since this is not used anyway but just passed along, it can simply be removed. This bug can be exposed even if you are not using the Intel Fortran compiler, because the class is loaded in an attempt to probe for all compilers, if the correct compiler is not found yet.
If Python has been built using a different runtime, for example using the GNU compiler in MSYS, the version string will of course not contain a reference to the MSVC runtime. Instead of attempting to build an import library for yet another runtime, we assume that the compiler used to build the extension is now the same as was used to build Python, and that it will pass the right runtime to the linker without any further command-line options.
|
LGTM, thanks @rolk |
|
Hmm, Appveyor is acting weird. The PR was already green, but when I merged the Appveyor builds changed to "cancelled" and the commit indicator to a red X. I don't think anything is wrong, but if the next PR fails then need to investigate. |
|
There are a lot of merged PRs that have the failed test marker that I think is the same problem. |
|
Will not backport, one of a series of PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of patches fixes problems in the compiler setup code when attempting to compile Numpy on Windows with a Python distribution which is not compiled with MSVC (but with for instance the GNU compiler in MSYS2). The old code contained some tests which assumed that a version string from the MSVC compiler was present in the system information string.