BLD: numpy compile with mingw32 on windows using official python3.6 binary #8690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pygsl on windows. I overloaded _fix_lib_args: This requires to call the parent class as the temporary build directory is used by numpy for some static libraries (e.g. npymath) to build numpy. This path is added to the link pathes by one of the parent classes. The comparison of the linked and run msvc / vcruntime library check was not traced down. The compiled numpy was tested on windows and worked to a large extend. The test results will be reported separately. Pygsl uses the preprossesor to check some definitions in GSL header. This worked for me after defining the preprocessor.
eric-wieser
reviewed
Feb 25, 2017
numpy/distutils/mingw32ccompiler.py
Outdated
| @@ -53,7 +53,9 @@ def get_msvcr_replacement(): | |||
| _TABLE = re.compile(r'^\s+\[([\s*[0-9]*)\] ([a-zA-Z0-9_]*)') | |||
|
|
|||
| # the same as cygwin plus some additional parameters | |||
| class Mingw32CCompiler(distutils.cygwinccompiler.CygwinCCompiler): | |||
| _parent = distutils.cygwinccompiler.CygwinCCompiler # super() useable for all | |||
| # python versions? | |||
There was a problem hiding this comment.
super(Mingw32Compiler, self) works on all python versions we care about, so better to do it that way
numpy/distutils/mingw32ccompiler.py
Outdated
| @@ -608,6 +638,10 @@ def check_embedded_msvcr_match_linked(msver): | |||
| # embedding | |||
| maj = msvc_runtime_major() | |||
| if maj: | |||
| if type(msver) == type(1.0) and msver == 14.0: | |||
There was a problem hiding this comment.
isinstance(msver, float) would be better here
| # that did not fix this issue. | ||
| # I needed this change to have the config tests run. This links to the | ||
| # vcruntime in the python directory. | ||
| # Can this be fixed by an appropriate environment variable? |
There was a problem hiding this comment.
Some of these comments feel like they belong in the PR, not the code (perhaps due to being first person)
eric-wieser
changed the title
charris
changed the title
added 3 commits
February 26, 2017 20:05
…inary numpy#8690 made change requests
-- python was compiled using ms c -- extension is compiled with mingw -- and the extension tries to makes ome file operations I disabled fromfile function and tofile method of multiarray using the preprocessor variable NPY_PYTHON_COMPILER_DIFFER. Then I could run the tests using run_tests.py without any crashes. This submission is to document the obtained results. Test output added as file
PS: I am using numpy as distributed from numpy project for production use.
I only compiled and tested it to find if my modifications to mingw32ccompiler.py
introduced any further regressions
|
Have you tried with current master? There have been a lot of changes related to windows builds. |
|
Commits should also be squashed. |
InessaPawson
added
52 - Inactive
|
Maybe a good start at the time. 5 years on, we have cygwin tests and mingw is running mostly I think. I don't think there is anything here of interest anymore. Closing, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes I found necessary to compile numpy and to configure numpy and pygsl on windows.
I overloaded _fix_lib_args: This requires to call the parent class as the
temporary build directory is used by numpy for some static libraries
(e.g. npymath) to build numpy. This path is added to the link pathes by
one of the parent classes.
The comparison of the linked and run msvc / vcruntime library check was
not traced down. The compiled numpy was tested on windows and worked to a
large extend. The test results will be reported separately.
Pygsl uses the preprossesor to check some definitions in GSL header.
This worked for me after defining the preprocessor.