MAINT: Fix deprecated escape sequences #8692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the escape sequences deprecated in Python 3.6 found in the tools directory. Note that this does not include the files in tools/swig/tests which are not even Python 3 compatible at this point.
Make the code a bit cleaner.
eric-wieser
reviewed
Feb 25, 2017
| "2.6" : "C:\python26\python26.exe"} | ||
| PYEXECS = {"2.5" : r"C:\python25\python.exe", | ||
| "2.4" : r"C:\python24\python24.exe", | ||
| "2.6" : r"C:\python26\python26.exe"} |
There was a problem hiding this comment.
Fixing a script for py3.6 compat that doesn't even know 2.7 exists? I guess this is still "more correct" python 2 code though, but perhaps we should be looking at removing this completely in another PR?
There was a problem hiding this comment.
Yes, and going to remove the whole tools/win32build in a later PR ;)
eric-wieser
approved these changes
Feb 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolsdirectory.tools/find_deprecated_escaped_characters.py.The files in
tools/swig/testsare not fixed, they are not even Python3 compatible at this point.