Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fixed small mistakes in numpy.copy documentation. #8702

Merged
merged 1 commit into from
Feb 26, 2017
Merged

DOC: Fixed small mistakes in numpy.copy documentation. #8702

merged 1 commit into from
Feb 26, 2017

Conversation

MSeifert04
Copy link
Contributor

@MSeifert04 MSeifert04 commented Feb 26, 2017

Including missing backticks around link, included a missing colon in
example and removed excessive indentation before "doctest skip" directive.

Including missing backticks around link, included a missing colon in
example and removed excessive indentation before "doctest skip directive".

[skip ci]
@MSeifert04
Copy link
Contributor Author

MSeifert04 commented Feb 26, 2017

It wasn't intended (editor setting) to change the other places:

  • trailing whitespaces and
  • blank lines containing whitespaces.

Should I revert these changes to avoid unnecessary changes to the git history and merge conflicts?

@charris
Copy link
Member

charris commented Feb 26, 2017

LGTM. Let's not worry about the whitespace. I plan on a big whitespace cleanup before branching 1.13.x, this is just a bit early...

@charris
Copy link
Member

charris commented Feb 26, 2017

The main problem with style cleanups is the loss of history. git blame ... turns up my name all over the place on that account. I'm not sure what the best way to deal with that is, google turns up a number of proposed solutions.

@charris charris merged commit c47198b into numpy:master Feb 26, 2017
@charris
Copy link
Member

charris commented Feb 26, 2017

Thanks @MSeifert04 .

@MSeifert04 MSeifert04 deleted the npcopy_docstring_fix branch February 26, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants