Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: added linalg.multi_dot to doc #8731

Merged
merged 1 commit into from
Mar 3, 2017
Merged

DOC: added linalg.multi_dot to doc #8731

merged 1 commit into from
Mar 3, 2017

Conversation

solarjoe
Copy link
Contributor

@solarjoe solarjoe commented Mar 2, 2017

No description provided.

@eric-wieser
Copy link
Member

eric-wieser commented Mar 2, 2017

Duplicate of #8723 ? Same complaint as before - Commit message should start with DOC:

@solarjoe
Copy link
Contributor Author

solarjoe commented Mar 2, 2017

Jup, sorry, I could not find where to change the name to add DOC:, but I found it now.
Now I am looking for the labels...

@eric-wieser
Copy link
Member

eric-wieser commented Mar 2, 2017

You didn't change the commit message though, only the PR name, which is irrelevant.

You can change the commit message with:

git commit --amend -m "DOC: added linalg.multi_dot to function list" && git push -f

As for labels, I'm afraid that github only allows those to be set by numpy members

@eric-wieser
Copy link
Member

eric-wieser commented Mar 3, 2017

Nevermind, I've fixed that for you. Force-pushing to someone else's master is a little weird. In future, you should try to make PRs on a branch

@eric-wieser eric-wieser merged commit 1b87427 into numpy:master Mar 3, 2017
@eric-wieser
Copy link
Member

@charris: Are documentation fixes like this backport candidates?

@ComFreek
Copy link

ComFreek commented May 8, 2017

Unfortunately, this change is still not reflected in the online documentation: https://docs.scipy.org/doc/numpy-dev/reference/routines.linalg.html
Or am I looking at the wrong site?

@eric-wieser
Copy link
Member

You're looking in the right place, but as the footer there says, it was last built in january.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants