BUG: Fix np.average for object arrays #8750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved from #8741... |
|
Please try to keep to one pr in future |
eric-wieser
reviewed
Mar 6, 2017
| @@ -341,6 +341,12 @@ def test_upcasting(self): | |||
| w = np.array([[1,2],[3,4]], dtype=wt) | |||
| assert_equal(np.average(a, weights=w).dtype, np.dtype(rt)) | |||
|
|
|||
| def test_object_dtype(self): | |||
| a = np.array([decimal.Decimal(x) for x in range(10)]) | |||
| + w = np.array([decimal.Decimal(1) for _ in range(10)]) | |||
There was a problem hiding this comment.
What is this plus doing here? Looks like you tried to copy a patch from the PR and paste it.
warut-vijit
force-pushed
the
master
branch
2 times, most recently
from
dfccde3
to
04b98f4
Compare
|
Can you edit the commit message to include "Fixes #8696" on the third line? |
|
Nevermind, have done so myself. Thanks @warut-vijit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved test for Object arrays from test_basic to test_object_dtype