Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Add HOME to the git environment. #8759

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Conversation

rkern
Copy link
Member

@rkern rkern commented Mar 9, 2017

git config files can contain ~ expansions that require $HOME to be defined.
Some installations of git have these in the global defaults now.

Before:

~/git/numpy master
❯ cat /usr/local/etc/gitconfig
[include]
    path = ~/.gitcinclude

[credential]
    helper = osxkeychain

~/git/numpy master
❯ python setup.py --version
error: could not expand include path '~/.gitcinclude'
fatal: bad config line 3 in file /usr/local/etc/gitconfig
error: could not expand include path '~/.gitcinclude'
fatal: bad config line 3 in file /usr/local/etc/gitconfig
/Users/rkern/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/setuptools/dist.py:294: UserWarning: The version specified (u'1.13.0.dev0+') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
  "details." % self.metadata.version
1.13.0.dev0+

After:

~/git/numpy fix/git-home
❯ python setup.py --version
1.13.0.dev0+c0be995

git config files can contain ~ expansions that require $HOME to be defined.
Some installations of git have these in the global defaults now.
@rgommers
Copy link
Member

rgommers commented Mar 9, 2017

LGTM

@rgommers rgommers added this to the 1.13.0 release milestone Mar 9, 2017
@charris
Copy link
Member

charris commented Mar 10, 2017

I have no idea what this does. What is ~/git/numpy?

@njsmith
Copy link
Member

njsmith commented Mar 10, 2017

@charris: I think he has a fancy multi-line command prompt, where ~/git/numpy is showing the current directory where he runs the command (and master and fix/git-home are the current branch).

@njsmith njsmith merged commit b1d232c into numpy:master Mar 10, 2017
@rkern
Copy link
Member Author

rkern commented Mar 10, 2017

Yes, fancy zsh prompt.

@rkern rkern deleted the fix/git-home branch March 10, 2017 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants