Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Include np. prefix in meshgrid examples #8799

Merged
merged 1 commit into from
Mar 21, 2017
Merged

DOC: Include np. prefix in meshgrid examples #8799

merged 1 commit into from
Mar 21, 2017

Conversation

klen1n
Copy link
Contributor

@klen1n klen1n commented Mar 20, 2017

DOC: Include np. prefix in meshgrid examples

@eric-wieser
Copy link
Member

eric-wieser commented Mar 20, 2017

Looks good, but commit message should begin with DOC: , so something like DOC: Include np. prefix in meshgrid examples

@klen1n klen1n changed the title fix function calls in examples Include np. prefix in meshgrid examples Mar 20, 2017
@klen1n klen1n changed the title Include np. prefix in meshgrid examples DOC: Include np. prefix in meshgrid examples Mar 20, 2017
@eric-wieser
Copy link
Member

Sorry @kl3n1nz , but that's just the issue title, not the commit message. You're not the first person to make that mistake. git commit --amend will allow you to change the message, then you can git push -f to update this PR.

Add "np." prefix to meshgrid calls for consistency
@klen1n
Copy link
Contributor Author

klen1n commented Mar 21, 2017

Thanks @eric-wieser, it should be okay now!

@eric-wieser
Copy link
Member

eric-wieser commented Mar 21, 2017

Will merge once it passes tests. In future, you can mark a documentation-only commit like this with [ci skip] in the message to not have them run at all

@eric-wieser eric-wieser merged commit 71a12bd into numpy:master Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants