-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Remove manual expansion of template loop for some ufuncs #8854
Conversation
LGTM pending tests. |
Appveyor looks to be broken in some way - none of the jobs seem to have run for any PRs... |
Why do some appveyor builds run at |
Because appveyor didn't support groups when we started using it. If I want to edit tests I need to log into appveyor as charris, where I run the numpy tests as a member of the numpy team. I don't know what the current situation with appveyor is, their web interface and documentation |
Oh, and if I want to switch my appveyor login, I need to delete their cookies. Perhaps I should disable cookies for that site. |
Appveyor looks to be rerunning tests for the past months/years. it did that once before, I had to spend a long time cancelling hundreds of tests to get it back to working. I think it is time to look for another place to run windows testing. Scipy looks to use https://circleci.com/. @rgommers Would you recommend circleci.com? Any oddities? |
SciPy uses CircleCI to build the html docs; it's nice for that because it keeps build artifacts around for inspection. Timeouts are pretty tight IIRC, and we haven't considered CircleCI for Windows builds. |
Appveyor is a massive pain to admin, but it's still the best option I think. |
Specifically, |
Beats me. Looks like the numpy account broke about 9 mos ago. I suspect that accounts for why merged PRs immediately show broken tests, which suggests that github merges are getting tested. |
Restarting it caused it to use the other hook, I think. Any objection to removing the |
The numpy project has a hook, which I deleted and readded, which cleared the queue. We weren't able to get it to display last time. It would be nice if everything ran through a single interface, but that will require some experimentation to figure out what works. It gets worse, the reason that I need to delete cookies to login to a different account is that there is no way to log out that I can discover. |
OK, I deleted the numpy project from the numpy account. Let's see what that does. |
And later we can try deleting from the charris account and adding to the numpy account. |
Good to merge? |
Yep, go ahead. |
Looks like if we want to set up an appveyor numpy organization account we will need a special email account, as appveyor accounts are identified with email addresses. |
There's templating here that loops over
@S@ = 'U', ''
. yet we don't actually use it to generate some of the functions.It's a lot less obvious where to add new ufuncs before this change.
Extracted from another PR, because this part needs no discussion