-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fixed README formatting #8859
Conversation
hi, please edit the actual commit title with |
This seems to be a recurring problem with first-time contributors - is there any way we can make this more obvious? |
[ci-skip]
@juliantaylor Does this look okay? @eric-wieser It was pretty clear in the contributing file. It was my mistake. Maybe including a bold phrase at the very start of the contributing file? Something specifying that it is mandatory on both the PR title and all the commits, to follow the commit message convention, otherwise the PR will be rejected. |
thanks, its |
To make it more obvious, we can include text or a checklist in the PR submission - that would be good for other things (docs, tests) as well. For the rest, it is better not to treat this as mandatory. We've never done that, and first-time contributors often struggle with rebases. So it's better to just point it out for next time and go on with the merge. Unless the commit message is completely uninformative of course, but a missing |
There are other options here to just letting it slide:
One thing to be clear about here - in other repos, like sphinx/sphinx, the PR message feels like a template (but seems not to be intended to be used as one) - we should make it clear that the template-text is instructions and not content to include in the PR. HTML comments work in GFM, so we could include brief instructions in there |
Prefixes are not that important. Merge-and-squash may be fine for single commit PRs, but for reasonably structured sets of commits it's not a good idea.
That sounds fine, for maintainers who want to do that.
Hmm, most bots are annoying. Plus the work to implement it (there's no homu-like bot that does exactly what we want) doesn't seem worth it.
Definitely, agreed |
I've also changed the URL to https://api.travis-ci.org/numpy/numpy.svg?branch=master which is a direct link to the Travis build page's status.