BUG: Ensure Errors are correctly checked when PyFloat_AsDouble is called #8883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongibbons
commented
Apr 1, 2017
| @@ -15,7 +15,7 @@ cdef extern from "Python.h": | |||
| object PyString_FromStringAndSize(char* c_string, int length) | |||
|
|
|||
| # Float API | |||
| double PyFloat_AsDouble(object ob) | |||
| double PyFloat_AsDouble(object ob) except? -1.0 | |||
There was a problem hiding this comment.
This causes cython to always check for raised exceptions when PyFloat_AsDouble returns -1.0.
This is what is recommended in the python API docs:
https://docs.python.org/2/c-api/float.html#c.PyFloat_AsDouble
simongibbons
force-pushed
the
fix-uniform-error
branch
from
adf5733
to
cfe04f0
Compare
…led. There was an error in np.random.uniform where if np.random.uniform were called with a type that throwed exceptions when it was converted to a float this exception wouldn't be raised. This bug was due to an issue where PyFloat_AsDouble was called but no check for PyErr_Occurred was performed after. This PR fixes the issue by ensuring that Cython will always emit a call to PyErr_Occurred if PyFloat_AsDouble returns -1.0 Fixes: numpy#8865
simongibbons
force-pushed
the
fix-uniform-error
branch
from
cfe04f0
to
a6c3d0e
Compare
|
On a skim of |
|
Thanks a lot, Simon! And nice Cython syntax, didn't know about that one. |
|
Should |
|
Yes I just noticed that one as well, looks like there are some cases where the same issue will occur. I'm just writing a failing test for that and will submit another PR with that. |
simongibbons
added a commit
to simongibbons/numpy
that referenced
this pull request
Apr 2, 2017
After numpy#8883 was merged it was noticed that the same problem was occuring with calls to PyInt_AsLong. Namely that PyErr_Occoured wasn't being checked if it returned -1 indicating an exception could have been thrown. This PR adds those checks as well as a regression test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in np.random.uniform where if np.random.uniform
were called with a type that throwed exceptions when it was converted
to a float this exception wouldn't be raised.
This bug was due to an issue where PyFloat_AsDouble was called but
no check for PyErr_Occurred was performed after.
This PR fixes the issue by ensuring that Cython will always emit a
call to PyErr_Occurred if PyFloat_AsDouble returns -1.0
Fixes: #8865