Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos. #8900

Merged
merged 2 commits into from
Apr 6, 2017
Merged

Fix typos. #8900

merged 2 commits into from
Apr 6, 2017

Conversation

crayxt
Copy link
Contributor

@crayxt crayxt commented Apr 6, 2017

Please review.

@eric-wieser
Copy link
Member

Thanks @crayxt.

In future, can you try to squash your commits, and put a relevant prefix like DOC: at the start of commit messages? (see the contribution guidelines)

@eric-wieser eric-wieser merged commit eb12b71 into numpy:master Apr 6, 2017
@crayxt
Copy link
Contributor Author

crayxt commented Apr 6, 2017

@eric-wieser thanks, I will mark the doc changes with DOC: prefix. As for squashing, I edited via Github, so only way to squash them I believe is at the PR merge time.

@eric-wieser
Copy link
Member

@crayxt: Yep, I figured you were probably going via github, so I did just squash at merge time to save us both effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
04 - Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crayxt @eric-wieser