ENH: Add ufunc.identity for hypot and logical_xor #8951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
reviewed
Apr 17, 2017
eric-wieser
force-pushed
the
more-identities
branch
from
815cc00
to
81e8dc0
Compare
|
Multiple axes seems like overkill, since that's really a test of the core ufunc machinery. I've added tests for reductions though, since they don't seem to be here at all |
eric-wieser
force-pushed
the
more-identities
branch
from
81e8dc0
to
acfb879
Compare
|
OK, definitely good enough! Since this is really a small (but nice!) addition, I'll go ahead and merge. |
eric-wieser
commented
Apr 17, 2017
| @@ -248,6 +248,11 @@ regarding "workspace" sizes, and in some places may use faster algorithms. | |||
|
|
|||
| .. _`LAPACK changelogs`: http://www.netlib.org/lapack/release_notes.html#_4_history_of_lapack_releases | |||
|
|
|||
| ``reduce`` of ``np.hypot.reduce`` and ``np.logical_xor`` allowed in more cases | |||
There was a problem hiding this comment.
Careless repetition of reduce here... Oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both are zero, since
0 ^ x == x,hypot(0, x) == x