-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: actually produce docs for as_strided #9039
Conversation
|
Good point. I guess this is a type of local build I can test, since it doesn't depend on the python source tree |
@@ -41,6 +41,7 @@ Indexing-like operations | |||
diag | |||
diagonal | |||
select | |||
as_strided |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be lib.stride_tricks.as_strided
.
But anyways, yes, you can definitely test this with a local docs build (cd doc
followed by make html
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make html
doesn't work on windows, because mkdir -p
means something different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But sphinx-build
works fine - and your suggestion is correct. Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's a bummer. I tried configuring a doc build on ReadTheDocs (see readthedocs.org/projects/numpy) but have not been able to get numpy building yet. I'm glad you figured out another way :)
c0bf4d8
to
02805d8
Compare
Works for me. Thanks Eric. |
Out of curiousity - is there a cronjob to produce https://docs.scipy.org/doc/numpy-dev/, or is that a manual endeavor? Would be good to have some way to sanity check formatting before a release, even if it's after a PR merge. |
@eric-wieser Scipy has infrastructure for checking documentation for coverage, but I don't know if it allows viewing the results. We should take a look at it in any case, I believe it is the CircleCI test. @rgommers Comment? |
No description provided.