MAINT: Update FutureWarning message. #9058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The future structured array assignment change warned about in dtype_transfer.c will take place in NumPy 1.14, not 1.13.
eric-wieser
approved these changes
May 5, 2017
There was a problem hiding this comment.
LGTM. I'm assuming that this warning isn't present elsewhere
For the sake of linking PRs, this is due to #6053 being kicked back to 1.14
|
Do we want a release note mentioning that this feature is delayed? |
Hadn't occurred to me, but probably a good idea. I'll add that. |
|
I documented the whole future change in the release notes as it was missing from the 1.12.0 notes. |
eric-wieser
reviewed
May 5, 2017
doc/release/1.13.0-notes.rst
Outdated
| in NumPy 1.14. Previously fields in the dst would be set to the value of the | ||
| identically-named field in the src. In numpy 1.14 fields will instead be | ||
| assigned 'by position': The n-th field of the dst will be set to the n-th | ||
| field of the src array, Note that the ``FutureWarning`` raised in NumPy 1.12 |
There was a problem hiding this comment.
Ok, this time I'm sure about commas - this one shouldn't be here!
charris
force-pushed
the
update-warning-message
branch
from
c86070d
to
88d6edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future structured array assignment change warned about in
dtype_transfer.c will take place in NumPy 1.14, not 1.13.