Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: if importing multiarray fails, don't discard the error message #9072

Merged
merged 1 commit into from
May 9, 2017
Merged

BUG: if importing multiarray fails, don't discard the error message #9072

merged 1 commit into from
May 9, 2017

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented May 9, 2017

This will hopefully make it easier to debug problems like those seen
in gh-8653.

@njsmith
BUG: if importing multiarray fails, don't discard the error message
2ff70d0 
This will hopefully make it easier to debug problems like those seen
in numpygh-8653.
@njsmith njsmith mentioned this pull request May 9, 2017
Closed
@njsmith
Copy link
Member Author

njsmith commented May 9, 2017

This is really hard to test automatically, but tested manually by doing ./runtests.py --python to get a REPL, opening another terminal, using that to manually corrupt build/testenv/lib/python3.5/site-packages/numpy/core/multiarray.cpython-35m-x86_64-linux-gnu.so, and then typing import numpy in the REPL.

@juliantaylor
Copy link
Contributor

looks useful, thanks

@juliantaylor juliantaylor merged commit 23b0cf3 into numpy:master May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@njsmith @juliantaylor