Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: fix test_basic failure on Windows #9097

Merged
merged 1 commit into from
May 11, 2017
Merged

TST: fix test_basic failure on Windows #9097

merged 1 commit into from
May 11, 2017

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented May 11, 2017

Echo is a command in the Windows command interpreter

Fix one test failure of numpy-1.13.0rc1+mkl on Windows:

NumPy version 1.13.0rc1
NumPy relaxed strides checking option: True
NumPy is installed in X:\Python36\lib\site-packages\numpy
Python version 3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 18:41:36) [MSC v.1900 64 bit (AMD64)]
nose version 1.3.7
<snip>
======================================================================
FAIL: test_basic (test_exec_command.TestExecCommand)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "X:\Python36\lib\site-packages\numpy\distutils\tests\test_exec_command.py", line 212, in test_basic
    self.check_nt(use_tee=0)
  File "X:\Python36\lib\site-packages\numpy\distutils\tests\test_exec_command.py", line 103, in check_nt
    self.assertEqual(s, 0)
AssertionError: 127 != 0

----------------------------------------------------------------------
Ran 6191 tests in 25.453s

FAILED (KNOWNFAIL=8, SKIP=11, failures=1) 

Echo is a command in the Windows command interpreter
@charris charris merged commit 315bbcd into numpy:maintenance/1.13.x May 11, 2017
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label May 11, 2017
@charris
Copy link
Member

charris commented May 11, 2017

@cgohlke Thanks @cgohlke . Could you forward port this so that it is against the master branch?

EDIT: nvm, already done.

@eric-wieser
Copy link
Member

Why would appveyor not catch this?

@charris
Copy link
Member

charris commented May 11, 2017

@eric-wieser I wondered that too. There is probably some difference in the test environment that matters.

@cgohlke
Copy link
Contributor Author

cgohlke commented May 11, 2017

The easiest explanation why this does not fail on AppVeyor would be that there is a echo.exe in the executable search path, e.g. as part of a git, mingw, or msys installation.

@charris
Copy link
Member

charris commented May 11, 2017

@cgohlke Likely, it is running in a miniconda environment.

@cgohlke
Copy link
Contributor Author

cgohlke commented May 11, 2017

The AppVeyor Visual Studio build environments have git installed (https://www.appveyor.com/docs/build-environment/#pre-installed-software).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants