BUG: Array ufunc reduce out tuple #9111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By mistake, any arguments to ufunc.reduce, ufunc.accumulate, and ufunc.reduceat that were None were removed, rather than just removing the 'out' argument. This is corrected here, with tests added.
|
Would it not be easier to wait until #9106 gets merged? |
|
This just makes more work. |
How so? This is the same branch targeted against a different head. If @mhvk pushed a commit to the other PR, it will appear here automatically, and presumably be tested as a backport too |
mhvk
force-pushed
the
array_ufunc_reduce_out_tuple
branch
from
20837e5
to
c47cb21
Compare
mhvk
force-pushed
the
array_ufunc_reduce_out_tuple
branch
3 times, most recently
from
2020e50
to
0a34fff
Compare
mhvk
force-pushed
the
array_ufunc_reduce_out_tuple
branch
4 times, most recently
from
15ed128
to
9785011
Compare
mhvk
force-pushed
the
array_ufunc_reduce_out_tuple
branch
from
9785011
to
ca49f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9106.
This ensures that the normal reduce, accumulate and reduceat methods can deal with getting out as a single-item tuple, which is needed to work with array_ufunc (see #9105). It builds on #9104; can be done together or in sequence.
note: I think I'm right that with my refcounting (not doing anything), but someone who understands this better please check...
Should update to match #9106 as that gets commits pushed.