BUG: pull request 9087 modifies a tuple after use #9196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my first backport, hope it is OK |
mhvk
added
00 - Bug
08 - Backport
|
@charris - could you check? I think it is OK, but I'm still a bit unsure about labels, including the commit title etc. |
|
Looks good. Keeping the same title helps when generating the 1.13.0 changelog and the tags should be the same except for the Backport tag. I like to remove the candidate tag after the backport is done and add the milestone to allow searching for missing backports. As a general rule, it is OK to merge backports without review. |
|
Note that I am considering leaving the Backport-candidate tag alone if the milestone is set on both PRs. The procedure isn't quite settled yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backported pull request #9195