BUG: Make extensions compilable with MinGW on Py2.7 #9319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original changeset 1c8ecc7 to make extensions compilable with MinGW used the base_prefix attribute unconditionally. However, this is not available in versions before Python 3.3. This changeset introduces a check for whether the attribute is available so that the code will work without errors also on Python 2.7. However, this may lead to surprising results when compiling in a virtualenv. Hat tip to Diorcet Yann (@diorcety) for pointing out this problem.
If we are using the virtualenv module in Python 2.7 (as opposed to venv in Python 3.3+), then the location of the base distribution is stored in the real_prefix attribute instead of the base_prefix attribute. This changeset adds the content of this attribute to the search paths if it exist (i.e. in practice, if we are running Python 2.7), so that the runtime libraries do not have to be duplicated in the virtualenv directory.
charris
added
00 - Bug
08 - Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #9280.
The original changeset 1c8ecc7 to make extensions compilable with MinGW
used the base_prefix attribute unconditionally. However, this is not
available in versions before Python 3.3.
This changeset introduces a check for whether the attribute is available
so that the code will work without errors also on Python 2.7. However,
this may lead to surprising results when compiling in a virtualenv.
Hat tip to Diorcet Yann (@diorcety) for pointing out this problem.