ENH: Show domain and window as kwargs in repr #9536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Aug 10, 2017
| @@ -260,7 +260,7 @@ def __init__(self, coef, domain=None, window=None): | |||
| self.window = window | |||
|
|
|||
| def __repr__(self): | |||
| format = "%s(%s, %s, %s)" | |||
| format = "%s(%s, domain=%s, window=%s)" | |||
There was a problem hiding this comment.
Only non-doc change is here
eric-wieser
commented
Aug 10, 2017
|
|
||
|
|
||
| class TestStr(object): | ||
| def test_polynomial_str(self): | ||
| res = str(poly.Polynomial([0, 1])) | ||
| tgt = 'poly([0., 1.])' | ||
| assert_(res, tgt) |
There was a problem hiding this comment.
Not a very effective test... (from 64fce7c)
|
LGTM, although it may break downstream doctests (@mhvk, astropy) and on that account needs a mention in the release notes. |
|
All in favour here! |
|
Under |
Also, update the docs with this new repr
…nything useful assert_ is not a substitute for assert_equal
eric-wieser
force-pushed
the
better-polynomial-repr
branch
from
edb23b0
to
1a0e863
Compare
|
Compatibility. |
|
Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit is better than implicit and all that.
Also, update the docs with this new repr - a bunch of these still printed the domain and window as floats in the default case.
Inspired a little by #9533.
It might be reasonable to not show the domain and window if either or both are the defaults