Add nested commands #290
Open
Add nested commands #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Let me know when it's rebased! |
deemp
force-pushed
the
add-nested-commands
branch
from
d161ef9
to
52b0eed
Compare
|
@zimbatm, rebased. |
|
There are some problems with types. I'll let you know when this PR is ready. |
|
@zimbatm, this PR is ready for a review. |
|
hmm, are you able to extract those cleanups in a separate PR? sorry the PR is a bit too large still |
Closed
deemp
force-pushed
the
add-nested-commands
branch
from
dbaba45
to
d45f45b
Compare
deemp
force-pushed
the
add-nested-commands
branch
3 times, most recently
from
8e1111a
to
312fae8
Compare
|
thanks, let me get those merged and then I'll do a deeper review here |
deemp
force-pushed
the
add-nested-commands
branch
7 times, most recently
from
4ac30bc
to
052ce67
Compare
deemp
force-pushed
the
add-nested-commands
branch
2 times, most recently
from
783d4ad
to
7f9ed41
Compare
deemp
force-pushed
the
add-nested-commands
branch
from
7f9ed41
to
11a6066
Compare
deemp
force-pushed
the
add-nested-commands
branch
from
11a6066
to
2100042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #216.
Based on #295, #297 because these PRs introduced some important changes.
commandsas an attrsetcommandsattrset (commands.<name>.*) isn't available when using TOML